Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installation path of adwatchd #847

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Fix installation path of adwatchd #847

merged 1 commit into from
Nov 13, 2023

Conversation

jibel
Copy link
Collaborator

@jibel jibel commented Nov 13, 2023

Replaced "ProgramData" with "Program Files" to follow MS documentation.

Closes: #834

UDENG-1699

Co-authored-by: Didier Roche <didrocks@ubuntu.com>
@codecov-commenter
Copy link

Codecov Report

Merging #847 (b41c98e) into main (95d68d5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #847   +/-   ##
=======================================
  Coverage   86.10%   86.10%           
=======================================
  Files          76       76           
  Lines        8599     8599           
=======================================
  Hits         7404     7404           
  Misses        866      866           
  Partials      329      329           

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@jibel jibel marked this pull request as ready for review November 13, 2023 12:14
@jibel jibel requested a review from a team as a code owner November 13, 2023 12:14
@jibel jibel requested review from a team and removed request for a team November 13, 2023 12:14
Copy link
Member

@didrocks didrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, this is a better place for this executable!

@jibel jibel merged commit 26199a4 into main Nov 13, 2023
6 checks passed
@jibel jibel deleted the fix-gh-834 branch November 13, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs recommend wrong directory ProgramData for deployment of Active Directory Watch Daemon (adwatchd.exe)
3 participants